Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 24.10.2 release #2055

Merged
merged 1 commit into from
May 10, 2021
Merged

Version 24.10.2 release #2055

merged 1 commit into from
May 10, 2021

Conversation

owenatgov
Copy link
Contributor

  • Allow modules to start after cookie consent (PR #2041)
  • Fix travel advice pages to use parent breadcrumbs (PR #2050)
  • Refactor heading logic in radio component (PR #2051)
  • Update design of metadata component (PR #2046)
  • Update scroll tracker config entries (PR #2052)

@bevanloon bevanloon temporarily deployed to govuk-publis-release-24-reln6r May 10, 2021 13:55 Inactive
andysellick
andysellick reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owenatgov you need to modify the Gemfile.lock as well?

@owenatgov
Copy link
Contributor Author

@andysellick I ran bundle && yarn as per the instructions and nothing changed.

@bevanloon bevanloon temporarily deployed to govuk-publis-release-24-wkg0fq May 10, 2021 14:32 Inactive
@owenatgov
Copy link
Contributor Author

Ah hang on. Re-running it sorted this out. Maybe I didn't save something properly.

@andysellick
Copy link
Contributor

@andysellick I ran bundle && yarn as per the instructions and nothing changed.

Interesting. Which instructions? I've only ever done this change manually.

@owenatgov
Copy link
Contributor Author

@andysellick These ones. It's fixed now either way.

@owenatgov owenatgov merged commit 95dea6a into master May 10, 2021
@owenatgov owenatgov deleted the release-24.10.2 branch May 10, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owenatgov @andysellick @bevanloon