Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travel advice pages to use parent breadcrumbs #2050

Merged
merged 1 commit into from
May 6, 2021

Conversation

sihugh
Copy link
Contributor

@sihugh sihugh commented May 6, 2021

Travel advice pages used to use parent breadcrumbs, but when we tried to simplify it, we missed this rule.

@bevanloon bevanloon temporarily deployed to govuk-publis-breadcrumb-uhzy3p May 6, 2021 14:37 Inactive
@sihugh sihugh marked this pull request as ready for review May 6, 2021 14:41
Travel advice pages used to use parent breadcrumbs, but when we tried to
simplify it, we missed this rule.
@sihugh sihugh force-pushed the breadcrumbs-travel-advice branch from 7b8b50b to 95b318a Compare May 6, 2021 14:52
@bevanloon bevanloon temporarily deployed to govuk-publis-breadcrumb-uhzy3p May 6, 2021 14:52 Inactive
@sihugh
Copy link
Contributor Author

sihugh commented May 6, 2021

Just pushed the correct changelog entry 🙄 . Thanks @alex-ju

@sihugh sihugh merged commit d69d65f into master May 6, 2021
@sihugh sihugh deleted the breadcrumbs-travel-advice branch May 6, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants