Update scroll tracker config entries #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
force-pushed
the
clean-up-scroll-tracker
branch
from
f6eb6ca to
cd1ef4b
Compare
alex-ju
changed the title
These URL now redirect to https://www.yourpension.gov.uk – no chance we can track on their site using this script 🙂
Redirect to `/guidance/covid-19-coronavirus-restrictions-what-you-can-and-cannot-do` and `/guidance/get-help-with-remote-education`, respectively
The headings on this page changed almost 2 years now, not sure there's any value in updating them since nobody seems to be checking data on it.
Redirects to `understandinguniversalcredit.gov.uk`
Redirects or missing headings
Hardcoding headings in this script seems far than ideal, but given the window of time we have available we'll continue with this approach and plan for a refactor.
alex-ju
force-pushed
the
clean-up-scroll-tracker
branch
from
cd1ef4b to
f58535a
Compare
theseanything
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I learned that our
scroll-trackerscript uses a large list of URLs and headings that are often outdated so I manually checked each page and remove the ones that don't fire events anymore because of redirects or content changes.The approach clearly has a massive flaw around maintenance, not to mention that PAs probably have no idea whether the URLs and headings are not in sync anymore or people don't reach a certain section which can potentially result in ill-informed data-based decisions.
After clean-up, we add a new entry for the results page on
next-steps-for-your-businessflow.Why
Because we ship code that has no effect on any page.
Trello card
Visual Changes
No visual changes