Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navigation header toggle button spacing #2483

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

injms
Copy link
Contributor

@injms injms commented Nov 29, 2021

What

Update navigation header link / toggle button spacing for the desktop layout.

Ticket: https://trello.com/c/aZhaaNyT

Preview page: https://components-gem-pr-2483.herokuapp.com/public

Why

To make the spacing in the desktoplayout look more balanced.

Visual Changes

Preview page: https://components-gem-pr-2483.herokuapp.com/public

Before

components publishing service gov uk_public (7)

After

govuk-publishing-components dev gov uk_public (18)

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2483 November 29, 2021 13:03 Inactive
@injms injms force-pushed the update-nav-header-spacing branch from 518827d to 7094db0 Compare November 29, 2021 13:05
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2483 November 29, 2021 13:05 Inactive
@mia-allers-gds
Copy link

This looks good, thank you @injms

@injms injms marked this pull request as ready for review November 29, 2021 13:32
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve the percy snapshot next. Looking lovely 👍

@injms injms force-pushed the update-nav-header-spacing branch from 7094db0 to 0d33cac Compare November 29, 2021 16:38
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-2483 November 29, 2021 16:39 Inactive
@injms injms merged commit c6ab384 into master Nov 29, 2021
@injms injms deleted the update-nav-header-spacing branch November 29, 2021 19:52
@chris-gds chris-gds mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants