Alter use of pseudo-underline mixin to allow for different button sizes #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
super-nav-menu-button-underline
branch
from
353be35 to
244b22b
Compare
|
Looks much better, thank you! |
chao-xian
approved these changes
Dec 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds options to the
pseudo-underlinemixin within the super nav header to allow them to take differentleftandrightattributes based on the button using the mixin.Why
Led by a bug report from Stephen McCarthy that the underline on the mobile menu button looks a bit weird.
The reason I've made the choice to alter how the mixin is initiated rather than just change the spacing is that this initial spacing is a conscious choice made in #2483 This maintains the intent of 2483 whilst fixing this issue.
Card
Visual Changes (mobile only)
Before
After