Improve print styles for layout-footer component #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
print-styles-layout-footer
branch
from
9a1587b to
2c2fcc0
Compare
matthillco
force-pushed
the
print-styles-layout-footer
branch
from
2c2fcc0 to
e646455
Compare
matthillco
force-pushed
the
print-styles-layout-footer
branch
from
e646455 to
7dccf80
Compare
matthillco
changed the title
AshGDS
approved these changes
Sep 2, 2024
app/assets/stylesheets/govuk_publishing_components/components/_layout-footer.scss
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_layout-footer.scss
Show resolved
Hide resolved
matthillco
force-pushed
the
print-styles-layout-footer
branch
from
a46fcac to
635c9e9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This improves the print styles for the
layout-footercomponent as part of the work to improve print styles for page layouts. Trello.Note that for consistency all variants of the layout-footer now render identically when printed .
Why
Although we made improvements to the
layout-footeras part of #4073, we did not look at how the component might interact with other components on the page. This PR further improves the component in context of page types.Visual Changes
Before and After: Component on a typical page