Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print styles for layout-footer component #4178

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Improve print styles for layout-footer component #4178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46b45d
Improve print styles for layout-footer component
matthillco Aug 28, 2024
635c9e9
Update CHANGELOG.md
matthillco Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

* Fix the search toggle in layout header ([PR #4163](https://github.com/alphagov/govuk_publishing_components/pull/4163))
* Replace 'unset' property in printed background colours ([PR #4184](https://github.com/alphagov/govuk_publishing_components/pull/4184))
* Improve print styles for layout-footer component ([PR #4178](https://github.com/alphagov/govuk_publishing_components/pull/4178))

## 43.0.1

Expand Down
35 changes: 32 additions & 3 deletions app/assets/stylesheets/govuk_publishing_components/components/_layout-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,39 @@
margin-bottom: 20px;
}

// stylelint-disable declaration-no-important
@include govuk-media-query($media-type: print) {
.govuk-footer {
background: none;
margin: 25mm 0 0;
padding: 5mm 0 0;
border-top: 2pt solid $govuk-print-text-colour;

.govuk-width-container {
margin: 0;
}
}

.govuk-footer__meta,
.govuk-footer__meta-item {
border: 0;
padding: 0;
margin: 0;
}

.govuk-footer__licence-description {
padding-right: 10mm;
}

.govuk-footer__copyright-logo {
min-width: auto;
padding-top: 13mm;
background-size: 15mm;
background-position: center top;
print-color-adjust: exact;
-webkit-print-color-adjust: exact;
}

.gem-c-layout-footer {
font-size: 12pt !important;
font-size: 10pt !important; // stylelint-disable-line declaration-no-important
}
}
// stylelint-enable declaration-no-important
2 changes: 1 addition & 1 deletion app/views/govuk_publishing_components/components/_layout_footer.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<% end %>
</div>

<hr class="govuk-footer__section-break">
<hr class="govuk-footer__section-break govuk-!-display-none-print">
<% end %>
<div class="govuk-footer__meta">
<div class="govuk-footer__meta-item govuk-footer__meta-item--grow">
Expand Down
Loading