Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component wrapper on reorderable list component #4474

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Use component wrapper on reorderable list component #4474

merged 2 commits into from
Dec 5, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Dec 3, 2024

What

  • Adds the component wrapper helper to the reorderable list component.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4474 December 3, 2024 15:38 Inactive
@AshGDS AshGDS force-pushed the reorderable-list-component-wrapper branch from 8a3c3cc to 1c0d50f Compare December 3, 2024 15:48
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4474 December 3, 2024 15:48 Inactive
@AshGDS AshGDS force-pushed the reorderable-list-component-wrapper branch from 1c0d50f to 21ed67d Compare December 3, 2024 15:52
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4474 December 3, 2024 15:52 Inactive
@AshGDS AshGDS marked this pull request as ready for review December 3, 2024 15:59
@AshGDS AshGDS requested a review from andysellick December 3, 2024 15:59
@AshGDS AshGDS self-assigned this Dec 5, 2024
@AshGDS AshGDS force-pushed the reorderable-list-component-wrapper branch from 21ed67d to 2f62756 Compare December 5, 2024 15:56
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4474 December 5, 2024 15:57 Inactive
@AshGDS AshGDS merged commit a61847b into main Dec 5, 2024
12 checks passed
@AshGDS AshGDS deleted the reorderable-list-component-wrapper branch December 5, 2024 15:59
@AshGDS AshGDS mentioned this pull request Dec 9, 2024
Closed
@KludgeKML KludgeKML mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees

@AshGDS AshGDS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci