Use component wrapper on share links component #4479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
share-links-component-wrapper
branch
from
da064f0 to
ff69a9d
Compare
AshGDS
force-pushed
the
share-links-component-wrapper
branch
from
ff69a9d to
e9c0908
Compare
andysellick
reviewed
Dec 9, 2024
|
@andysellick Weird...I think may be a rebase went wrong? It looks like it ended up in #4474 |
|
That is weird. And I approved that one, and didn't raise anything at the time... so yeah, bit confused here. Oh well. You've done the work already 😁 🤷 |
|
@andysellick 😅 Happy to revert the other PR, and separate the commits if you think it's worth it - will close this PR for now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
share linkscomponent.Why
As the trello card states:
Visual changes
None.