Make header text colour black when focused #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we changing it here and not where it’s originally defined? |
|
@robinwhittleton because it looked like other stuff related to focus was set in the accessibility file, including the existing line that was setting links to black. At best it looks like we're setting anchors in the header to black twice? |
|
I’d rather not apply this where you’ve suggested. It should probably be an extra |
This is moved to the header stylesheet, where the proposition name is being overridden to white.
gemmaleigh
force-pushed
the
service-name-contrast
branch
from
8b59a4a
to
7fe739f
Compare
|
I have made the changes @robinwhittleton suggested and also tested these changes locally.
|
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 16, 2017
- Fix EJS template (PR #270) - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header (PR #278) - Add `text-decoration-skip: ink` to all links on GOV.UK (PR #281) - Improve contrast of links when focused (PR #272) - Make header text colour black when focused (PR #274)
Merged
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 29, 2017
- Fix EJS template (PR #270) - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header (PR #278) - Add `text-decoration-skip: ink` to all links on GOV.UK (PR #281) - Improve contrast of links when focused (PR #272) - Make header text colour black when focused (PR #274)
robinwhittleton
pushed a commit
that referenced
this pull request
Mar 29, 2017
- Fix EJS template (PR #270) - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header (PR #278) - Add `text-decoration-skip: ink` to all links on GOV.UK (PR #281) - Improve contrast of links when focused (PR #272) - Make header text colour black when focused (PR #274)
fofr
pushed a commit
to alphagov/static
that referenced
this pull request
May 5, 2017
# 0.20.0 - Fix EJS template - PR #270 - alphagov/govuk_template#270 - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header - PR #278 - alphagov/govuk_template#278 - Add `text-decoration-skip: ink` to all links on GOV.UK - PR #281 - alphagov/govuk_template#281 - Improve contrast of links when focused - PR #272 - alphagov/govuk_template#272 - Make header text colour black when focused - PR #274 - alphagov/govuk_template#274 # 0.19.2 - Increase skiplink colour contrast - PR #263 - alphagov/govuk_template#263 - Fix Scala compile issues for Play template - PR #261 - alphagov/govuk_template#261 # 0.19.1 - Have focus outline appear outside of element rather than covering it in Safari and Chrome - PR #259 - alphagov/govuk_template#259
ushkarev
added a commit
to ministryofjustice/django-govuk-template
that referenced
this pull request
Aug 17, 2017
… following suit on alphagov/govuk_template#274
ushkarev
added a commit
to ministryofjustice/django-govuk-template
that referenced
this pull request
Aug 18, 2017
… following suit on alphagov/govuk_template#274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header text has poor contrast when focused as it's white on yellow. This PR changes it to black on yellow to match other anchors on the page.
Also changes to use
$text-colourfrom black, which felt more consistent.Before:
After: