Add stageprompt to static (not compiled into application.js) #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is not going to be included into either application.js or header_footer_only.js it should probably live in the frontend toolkit. That is how we should share non-header-footer code in future. |
|
@edds does that work for non-ruby things too? Currently it's being used in licensify (Scala app) and FCO transactions. We just want to have a single place where services can reference this if they need it. |
|
@jabley: The frontend toolkit is just a git repo with assets in it. Anything that can read a folder structure can use it. There is a gem to wrap it but you don't have to use that. The service manual for example just uses a git submodule to include it: .gitmodules. |
|
Moving to frontend toolkit... |
fofr
pushed a commit
that referenced
this pull request
May 5, 2017
# 0.20.0 - Fix EJS template - PR #270 - alphagov/govuk_template#270 - Add `theme-color` support to make the page surround in Chrome’s tab view on Android match the black GOV.UK header - PR #278 - alphagov/govuk_template#278 - Add `text-decoration-skip: ink` to all links on GOV.UK - PR #281 - alphagov/govuk_template#281 - Improve contrast of links when focused - PR #272 - alphagov/govuk_template#272 - Make header text colour black when focused - PR #274 - alphagov/govuk_template#274 # 0.19.2 - Increase skiplink colour contrast - PR #263 - alphagov/govuk_template#263 - Fix Scala compile issues for Play template - PR #261 - alphagov/govuk_template#261 # 0.19.1 - Have focus outline appear outside of element rather than covering it in Safari and Chrome - PR #259 - alphagov/govuk_template#259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/alphagov/stageprompt
Proposed plan is to have this in static but only have applications include it where it is needed.