Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-13313 Show success banner when all Worldpay tasks are complete #4415

Merged
merged 4 commits into from
Jan 20, 2025
Merged

PP-13313 Show success banner when all Worldpay tasks are complete #4415

merged 4 commits into from
Jan 20, 2025

Conversation

DomBelcher
Copy link
Contributor

WHAT

  • Add a success banner to show when the final Worldpay task has been completed
  • Because these can be completed in any order, checking if the banner can be shown requires re-checking the status of the Worldpay tasks
  • Cypress tests will be fixed when run-amock is updated to make the stubbing easier

@DomBelcher DomBelcher force-pushed the PP-13313/success-banner branch from 83a0064 to 4e54c2d Compare January 20, 2025 09:50
@DomBelcher DomBelcher force-pushed the PP-13313/success-banner branch from 0ffd444 to d95de37 Compare January 20, 2025 09:57
@DomBelcher DomBelcher marked this pull request as ready for review January 20, 2025 10:11
oswaldquek
oswaldquek approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@oswaldquek oswaldquek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DomBelcher DomBelcher merged commit 9b008a7 into master Jan 20, 2025
14 checks passed
@DomBelcher DomBelcher deleted the PP-13313/success-banner branch January 20, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oswaldquek oswaldquek oswaldquek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DomBelcher @oswaldquek