Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update organisation classes #9647

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update organisation classes #9647

merged 1 commit into from
Dec 13, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Nov 25, 2024

What / Why

These were renamed in govuk-frontend. We had 'middle man' classes in govuk_publishing_components that would redirect these old class names to the correct class name in govuk-frontend. However if we update the model, we can then remove these classes from govuk_publishing_components.
@AshGDS AshGDS self-assigned this Nov 25, 2024
@AshGDS AshGDS marked this pull request as ready for review November 25, 2024 11:43
@AshGDS AshGDS requested a review from andysellick December 13, 2024 14:01
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 😁

@AshGDS AshGDS merged commit f2da467 into main Dec 13, 2024
20 checks passed
@AshGDS AshGDS deleted the update-class-nov-24 branch December 13, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants