Change department brand class names #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change required for upcoming govuk-frontend 5.5 upgrade - class names have been renamed to remove the 'and', without this change the brand colour will not appear on department pages
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename two of the department brand class names to match what they will shortly be called in
govuk-frontend.We'll be rolling out this change in alphagov/govuk_publishing_components#4160 and will merge and deploy this PR at the appropriate time.
Why
These class names were updated in
govuk-frontendbetween 5.1 (current version ingovuk_publishing_components) and 5.5 (about to be upgraded to).Visual changes
None.
Trello card: https://trello.com/c/l2yxZZ9k/274-upgrade-to-govuk-frontend-55