Add tags for multiple selection

[cristian-spiescu]

Hi!

Just like the original "Redmine UP Tags plugin", there is an issue when trying to add a tag for a multiple selection. E.g. I have task1 and task2 as follows:

I select the 2 tasks, and I click on "add tag":

I want to add "tag2" to both tags:

The above dialog behaves actually like "set tags". Not like "add tags".

• if I add "tag2" in the textbox (so I have tag1, tag2) => both tasks will have tag1, tag2
  

• if I remove tag1 and let only tag2 in the text box => both tasks will have tag2. This will REMOVE tag1 from task1
  

Actually this is the reason why we cannot use this plugin. People may want to bulk add some tags, and they may end in corrupting the tasks.

Thanks in advance!
Cristian

[cristian-spiescu]

I find it interesting that this issue wasn't discovered until now, and that it seems not to bother people. Anyway, for us, it's a showstopper. We'll try to fix it and propose a PR. I hope the repo policy is to review and try to merge PRs from users external to the project. It's a bit challenging because we are not Ruby devs, but let's see what we manage to do.

[Theodorson]

Hi,

I am colleague with @cristian-spiescu and I made a fix for this issue. This is the PR for fixing issue #27. Please look in PR for release notes which contains explanations of what I did and screenshots.

[Theodorson]

Hi,

I fixed the tests. Now I think the PR can be merged. Can you please approve to run the build again ?

[Theodorson]

Hi,
I fixed linter too. I didn't modified with nothing the places with problems, I don't know how it passed in the past, anyway, now I think is fine. Can you please approve to run the build again ?

[Theodorson]

Hi,
Was one more problem with a slim file. Can you please approve to run the build again ?

[Theodorson]

Hi,
Could you please approve to trigger another build ?

[alexandermeindl]

This is fixed with #39