Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'Add tags'. Added 'Edit tags' #39

Merged
merged 4 commits into from
Dec 18, 2022
Merged

Conversation

Theodorson
Copy link

No description provided.

@alexandermeindl
Copy link
Contributor

alexandermeindl commented Nov 29, 2022

I'll not except this PR, because other code is overwritten, which changed in the last weeks. Please fix this. Also why do you think you can change the release version?

@Theodorson
Copy link
Author

I've fixed it. Sorry. I don't understand the part about release version.

@Theodorson
Copy link
Author

Hi @alexandermeindl,

I've fixed linter and tests. Could you please trigger another build ?

@Theodorson
Copy link
Author

Hi @alexandermeindl ,

Could you please trigger another build ? A problem still exists ?

@alexandermeindl alexandermeindl merged commit 0b26daf into alphanodes:main Dec 18, 2022
@alexandermeindl
Copy link
Contributor

Hi @Theodorson,

thanks for you contribution, it is now merged to main branch!

alexandermeindl added a commit that referenced this pull request Dec 18, 2022
… issues do not use this additional note, too
@alexandermeindl
Copy link
Contributor

Hii @Theodorson,
I found a bug with your pr: no journal entries are created in issues, if you add tags. Can you provide a fix for it in a new pr?

@Theodorson
Copy link
Author

Hi @alexandermeindl
I understand add tags is not doing the same with the save tags from issue page right ? I've tested with a older branch without my changes and also doesn't works. I'm not sure is a bug from my PR. I would like to repair/add this behavior what should exists.
image
image

@alexandermeindl
Copy link
Contributor

Hi @Theodorson,
this would be great!

Journal for tags is tricky, I spent some hours, days for it on other actions (edit form, tag edit on show, creating new issues, deleting tags,...). It was not easy to find a solution, which worked for all this actions. Maybe you are right, that adding tags on context-menu never worked with journal entries.

It would be really great if you have time for it and can find a solution.

@Theodorson
Copy link
Author

Hi @alexandermeindl,

Happy new year!

I was in holiday. I will try to add this feature when I will have some free time, I spoke with a colleague and I think we found a solution. I will come back with news about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants