Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libvips #29

Closed
wants to merge 4 commits into from
Closed

Libvips #29

wants to merge 4 commits into from

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Feb 13, 2016

Builds libvips with various optional dependencies enabled. One of the optionally-enabled dependencies is mozjpeg, which I've provided on its own in #28.

This was referenced Feb 13, 2016
Closed
Merged
@lovell lovell mentioned this pull request Jun 9, 2016
Closed
@AVVS
Copy link
Contributor

AVVS commented Jun 9, 2016

Completely missed that PR and was struggling to implement an APK for the first time :) Well, I've succeeded, but it seems have too many redundant packages in my own (https://gist.github.com/AVVS/c56026dee71f7aff29167532d2b96960). Can we get this into community repo and also bump libvips to 8.3.1 as the current version?

@ncopa @wjordan ?

@jirutka jirutka added the S-needs-review Needs thorough review, should not be merged before that label Jun 9, 2016
@ncopa
Copy link
Contributor

ncopa commented Jul 20, 2016

seems like mozjpeg conflicts with libjpeg-turbo. They both provide same library file name usr/lib/libturbojpeg.so.0 which means that both cannot be installed at the same time. This means that we have the following options:

  • rename the library to something else for mozjpeg (why is it not called libmozjpeg.so.0 already?)
  • replace libjpeg-turbo with mozjpeg system wide
  • make libvips use libjpeg-turbo instead of mozjpeg

mozjpeg is designed for a special case while libjpeg-turbo is designed for more general purpose, so I don't think just replacing libjpeg-turbo with mozjpeg is a good idea.

@ncopa
Copy link
Contributor

ncopa commented Jul 20, 2016 •
edited
Loading

i pushed the package as testing/vips with some minor modifications. thanks!

@ncopa ncopa closed this Jul 20, 2016
algitbot pushed a commit that referenced this pull request Oct 2, 2017
@jirutka
community/czmq: disable on s390x
2aaa5a7 
        Start 28: zproxy
  28/30 Test #28: zproxy ...........................***Timeout  60.01 sec
        Start 29: zrex
  29/30 Test #29: zrex .............................   Passed    0.00 sec
        Start 30: zsys
  30/30 Test #30: zsys .............................   Passed    0.20 sec

  97% tests passed, 1 tests failed out of 30

  Total Test time (real) =  73.61 sec

  The following tests FAILED:
  	 28 - zproxy (Timeout)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-needs-review Needs thorough review, should not be merged before that
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjordan @AVVS @ncopa @jirutka