-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libvips-dev apk for alpine-linux packaging test #359
Conversation
Thanks Will, this is a much better approach. https://circleci.com/gh/lovell/sharp/107 is reporting the following error:
This looks like an S3 permission thing. Is this something you can fix? |
cb1c921
to
e149e60
Compare
vips requires main/gettext-0.19.7r1 for aports commit 4ef70b432b05b720f7f144c2060550749d378205 to link correctly.
oops- i forgot to add the I tried linking against tested locally and got |
Use libvips-dev apk for alpine-linux packaging test
Fantastic, thank you for all your help to get this working. |
@wjordan could you update your APK so that it works with :edge again ? Seem to be failing to build now :( |
@AVVS OK, I took a look, the published packages should be working again. I had to rebuild the APKs because the It looks like the new |
@wjordan thanks a lot, works like a charm now :) @lovell not sure if there is anything you need to look at:
|
The overlay logic is relatively stack-intensive so the segfault could be related to an overflow; I'll take a look. |
Backtrace from overlay test segfault:
The use of Node v4 on Alpine leads me to believe this could be related to nodejs/node#4382 so I'm happy to ignore this one until that fix lands in LTS. |
This updates the alpine-linux packaging test to use the libvips-dev apk (currently being served from a custom s3 repository location; see alpinelinux/aports#29 for the upstream APK submission).
I realized that a Docker image probably isn't the most maintainable approach for distributing a compiled-library meant to be used as a base image for other projects, and found it easier to leverage the existing OS package management systems, in this case APKs (which are basically just tar-packages of the project's files, with some metadata). Following the APK conventions, the compiled
libvips
package is separated intolibvips
which is the compiled runtime library, andlibvips-dev
which includes the development headers needed for building projects linking to it. So for a packaging-test for Sharp, we want to link to thelibvips-dev
package.Note- I've also created a
node-sharp
package which provides a pre-compiled Sharp on Alpine Linux- see alpinelinux/aports#30 for that upstream APK submission.