Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change search text in top bar if on Mac OS #2437

Closed
2 tasks done
george-gca opened this issue May 24, 2024 · 0 comments
Closed
2 tasks done

Change search text in top bar if on Mac OS #2437

george-gca opened this issue May 24, 2024 · 0 comments
Labels
enhancement

Comments

@george-gca
Copy link
Collaborator

Have you checked that your feature request isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my feature request.
  • Yes, I have checked that this feature request isn't already filed.

Description & Motivation

Since the hotkeys for search in Mac OS are ⌘k instead of ctrl k, this can be a little misleading for the user.

Pitch

Change the text next to the search button depending on the platform. For example, if the user is accessing the site on a mac they should use ⌘k instead of ctrl k

Alternatives

No response

Additional context

No response
ajyey added a commit to ajyey/ajyey.github.io that referenced this issue May 29, 2024
@ajyey
Dynamically sets the search shortcut key based on platform
12b476e 
This addresses issue alshedivat#2437
@ajyey ajyey mentioned this issue May 29, 2024
Merged
george-gca pushed a commit that referenced this issue May 31, 2024
@ajyey
Feature: Dynamically sets the search shortcut key based on the user's…
afc56cc 
… platform (#2461)

This addresses issue #2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
JyotsnaT pushed a commit to JyotsnaT/jyotsnat.github.io that referenced this issue Jun 6, 2024
@ajyey @JyotsnaT
Feature: Dynamically sets the search shortcut key based on the user's…
b326cc6 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
siril-teja pushed a commit to siril-teja/siril-teja.github.io-old that referenced this issue Jun 19, 2024
@ajyey @siril-teja
Feature: Dynamically sets the search shortcut key based on the user's…
64ee035 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
karapostK pushed a commit to karapostK/karapostK.github.io that referenced this issue Jul 4, 2024
@ajyey @Karapost
Feature: Dynamically sets the search shortcut key based on the user's…
7080c60 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this issue Aug 13, 2024
@ajyey @Suraj-Bhor
Feature: Dynamically sets the search shortcut key based on the user's…
397e87e 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this issue Oct 13, 2024
@ajyey
Feature: Dynamically sets the search shortcut key based on the user's…
55e6c9d 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
avishekanand pushed a commit to avishekanand/al-folio-homepage that referenced this issue Oct 22, 2024
@ajyey
Feature: Dynamically sets the search shortcut key based on the user's…
b4e5491 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@george-gca