Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Dynamically sets the search shortcut key based on the user's platform #2461

Merged
merged 6 commits into from
May 31, 2024
Merged

Feature: Dynamically sets the search shortcut key based on the user's platform #2461

merged 6 commits into from
May 31, 2024

Conversation

ajyey
Copy link
Contributor

@ajyey ajyey commented May 29, 2024 •
edited
Loading

This addresses issue #2437 by:

  • Adding a new script that dynamically sets the search keyboard shortcut by checking what platform the user is currently using
  • Loading this script in default.liquid
SCR-20240529-cdfe

CheariX
CheariX reviewed May 29, 2024
View reviewed changes
assets/js/shortcut-key.js Outdated Show resolved Hide resolved
assets/js/shortcut-key.js Outdated Show resolved Hide resolved
@ajyey
Copy link
Contributor Author

ajyey commented May 29, 2024 •
edited
Loading

@CheariX thinking about it a bit more, would it make sense to also use the unicode for ctrl to keep it consistent across different platforms or are we ok with the way we have it here?

CheariX
CheariX reviewed May 29, 2024
View reviewed changes
assets/js/shortcut-key.js Outdated Show resolved Hide resolved
@CheariX
Copy link
Contributor

CheariX commented May 29, 2024

@CheariX thinking about it a bit more, would it make sense to also use the unicode for ctrl to keep it consistent across different platforms or are we ok with the way we have it here?

Hm. Good question! Is there a unicode for ctrl? I think on Mac, you sometimes use ⌃ instead of the string ctrl.
But on Windows/Linux, ctrl is very common.
I don't have a preference on that.

@ajyey
Copy link
Contributor Author

ajyey commented May 29, 2024

@CheariX thinking about it a bit more, would it make sense to also use the unicode for ctrl to keep it consistent across different platforms or are we ok with the way we have it here?

Hm. Good question! Is there a unicode for ctrl? I think on Mac, you sometimes use ⌃ instead of the string ctrl.

But on Windows/Linux, ctrl is very common.

I don't have a preference on that.

Understood. I'll leave it as is then

@ajyey ajyey changed the title Dynamically sets the search shortcut key based on the user's platform Feature: Dynamically sets the search shortcut key based on the user's platform May 30, 2024
@ajyey ajyey requested a review from CheariX May 30, 2024 20:51
george-gca
george-gca reviewed May 31, 2024
View reviewed changes
_layouts/default.liquid Outdated Show resolved Hide resolved
assets/js/shortcut-key.js Outdated Show resolved Hide resolved
@ajyey ajyey requested a review from george-gca May 31, 2024 16:49
@george-gca george-gca merged commit afc56cc into alshedivat:master May 31, 2024
3 checks passed
@ajyey ajyey deleted the feature/search-shortcut-key branch June 4, 2024 00:39
JyotsnaT pushed a commit to JyotsnaT/jyotsnat.github.io that referenced this pull request Jun 6, 2024
@ajyey @JyotsnaT
Feature: Dynamically sets the search shortcut key based on the user's…
b326cc6 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
siril-teja pushed a commit to siril-teja/siril-teja.github.io-old that referenced this pull request Jun 19, 2024
@ajyey @siril-teja
Feature: Dynamically sets the search shortcut key based on the user's…
64ee035 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
karapostK pushed a commit to karapostK/karapostK.github.io that referenced this pull request Jul 4, 2024
@ajyey @Karapost
Feature: Dynamically sets the search shortcut key based on the user's…
7080c60 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this pull request Aug 13, 2024
@ajyey @Suraj-Bhor
Feature: Dynamically sets the search shortcut key based on the user's…
397e87e 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
@ajyey
Feature: Dynamically sets the search shortcut key based on the user's…
55e6c9d 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
avishekanand pushed a commit to avishekanand/al-folio-homepage that referenced this pull request Oct 22, 2024
@ajyey
Feature: Dynamically sets the search shortcut key based on the user's…
b4e5491 
… platform (alshedivat#2461)

This addresses issue alshedivat#2437 by:
- Adding a new script that dynamically sets the search keyboard shortcut
by checking what platform the user is currently using
- Loading this script in `default.liquid`

<img width="1150" alt="SCR-20240529-cdfe"
src="https://github.com/alshedivat/al-folio/assets/16251412/7c4125fc-5028-422f-97d5-0df729e30fa7">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-gca george-gca george-gca approved these changes

@CheariX CheariX Awaiting requested review from CheariX

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajyey @CheariX @george-gca @alshedivat