Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend TimeSeriesImputer to handle multiple series #4291
Extend TimeSeriesImputer to handle multiple series #4291
Changes from 5 commits
c8addb4
eb96bca
f4d532d
c1dda0f
278d953
021dfec
c1acd19
24d5e05
d5b4652
96f43a1
a12d92d
f99e3d1
3938001
b3c8392
6dec926
d03ad74
3f8118a
5435b19
41c277e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 286 in evalml/pipelines/components/component_base.py
Codecov / codecov/patch
evalml/pipelines/components/component_base.py#L286
Check warning on line 151 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L147-L151
Check warning on line 229 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L229
Check warning on line 232 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L232
Check warning on line 235 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L235
Check warning on line 241 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L241
Check warning on line 244 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L244
Check warning on line 248 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L248
Check warning on line 269 in evalml/pipelines/components/transformers/imputers/time_series_imputer.py
Codecov / codecov/patch
evalml/pipelines/components/transformers/imputers/time_series_imputer.py#L269
Check warning on line 727 in evalml/tests/component_tests/test_time_series_imputer.py
Codecov / codecov/patch
evalml/tests/component_tests/test_time_series_imputer.py#L727
Check warning on line 744 in evalml/tests/component_tests/test_time_series_imputer.py
Codecov / codecov/patch
evalml/tests/component_tests/test_time_series_imputer.py#L731-L744
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would benefit from another test (parametrized here) where only some of the columns are NaN, but not all of them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Sorry, should have clarified 😅 I meant a test where some of the columns are all NaN, so we drop some columns and impute or pass through others!
Check warning on line 756 in evalml/tests/component_tests/test_time_series_imputer.py
Codecov / codecov/patch
evalml/tests/component_tests/test_time_series_imputer.py#L747-L756