Revert "Disable file system tests broken by infra change (envoyproxy#…

…33117)" (envoyproxy#33123) This reverts commit 2d368c3. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk · Apr 29, 2024 · befc494 · befc494
1 parent 532f66a
commit befc494
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/test/extensions/common/async_files/async_file_handle_thread_pool_test.cc b/test/extensions/common/async_files/async_file_handle_thread_pool_test.cc
@@ -139,8 +139,6 @@ TEST_F(AsyncFileHandleTest, WriteReadClose) {
 }
 
 TEST_F(AsyncFileHandleTest, LinkCreatesNamedFile) {
-  // TODO(https://github.com/envoyproxy/envoy/issues/33114) Enable
-  GTEST_SKIP();
   auto handle = createAnonymousFile();
   std::promise<absl::StatusOr<size_t>> write_status_promise;
   // Write "hello" to the anonymous file.

diff --git a/test/extensions/http/cache/file_system_http_cache/file_system_http_cache_test.cc b/test/extensions/http/cache/file_system_http_cache/file_system_http_cache_test.cc
@@ -1241,15 +1241,11 @@ class FileSystemHttpCacheTestDelegate : public HttpCacheTestDelegate,
 };
 
 // For the standard cache tests from http_cache_implementation_test_common.cc
-// TODO(https://github.com/envoyproxy/envoy/issues/33114) Enable
-GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(HttpCacheImplementationTest);
-/*
 INSTANTIATE_TEST_SUITE_P(FileSystemHttpCacheTest, HttpCacheImplementationTest,
                          testing::Values(std::make_unique<FileSystemHttpCacheTestDelegate>),
                          [](const testing::TestParamInfo<HttpCacheImplementationTest::ParamType>&) {
                            return "FileSystemHttpCache";
                          });
-*/
 
 TEST(Registration, GetCacheFromFactory) {
   HttpCacheFactory* factory = Registry::FactoryRegistry<HttpCacheFactory>::getFactoryByType(

diff --git a/test/per_file_coverage.sh b/test/per_file_coverage.sh
@@ -42,7 +42,6 @@ declare -a KNOWN_LOW_COVERAGE=(
 "source/extensions/filters/network/sni_cluster:88.9"
 "source/extensions/filters/network/wasm:76.9"
 "source/extensions/http/cache/simple_http_cache:95.9"
-"source/extensions/http/cache/file_system_http_cache:30.0" # TODO(https://github.com/envoyproxy/envoy/issues/33114)
 "source/extensions/rate_limit_descriptors:95.0"
 "source/extensions/rate_limit_descriptors/expr:95.0"
 "source/extensions/stat_sinks/graphite_statsd:82.8" # Death tests don't report LCOV