Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file system tests broken by infra change #33117

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

ravenblackx
Copy link
Contributor

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Raven Black <ravenblack@dropbox.com>
Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #33117 was opened by ravenblackx.

see: more, trace.

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

Signed-off-by: Raven Black <ravenblack@dropbox.com>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alyssawilk
Copy link
Contributor

I'm going to prefer this to mine as it lowers coverage and false merge as CI is already broken.

@alyssawilk alyssawilk merged commit 2d368c3 into envoyproxy:main Mar 26, 2024
28 of 30 checks passed
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Mar 26, 2024
…33117)"

This reverts commit 2d368c3.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk added a commit that referenced this pull request Mar 26, 2024
…33123)

This reverts commit 2d368c3.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
…33117)" (envoyproxy#33123)

This reverts commit 2d368c3.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants