-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Hopefully this name is more descriptive.
It looks like we'll be adding a single host to the For example - Drupal can be configured with
|
Very interesting, I didn't know that! You're right, this PR doesn't address the multiple-read-replica scenario. I don't think it's worth bundling that into this PR because it's big enough as is. But maybe it makes sense to add a numerical suffix to the environment variable so that multiple read-replicas can be added in future. e.g. make the variable in this PR |
...or better, use |
Drupal can make use of multiple read-replicas. This APB doesn't address that possiblity, but it should in future, so pluralise the interfacing environment variable so that multiple space-separated hosts can be defined.
This is ready for review, but please don't merge/deploy until next week to avoid any issues over the weekend. |
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* # This is a combination of 3 commits. # This is the 1st commit message: Add read replica access. Updates govcms-deploy to use the read replica for Adds database config for the read replica Introduces MARIADB_HOST_READREPLICA environment variable to control the mysql host. # This is the commit message #2: Add replicas to the default connection. # This is the commit message #3: Update .docker/images/govcms8/scripts/govcms-deploy * Add read replica access. Updates govcms-deploy to use the read replica for Adds database config for the read replica Introduces MARIADB_HOST_READREPLICA environment variable to control the mysql host. Add replicas to the default connection. Update .docker/images/govcms8/scripts/govcms-deploy Code review updates. - Return early if host is unavailable. - Updated db_conf settings for reusability. - Redirect show tables to stderr. - Reverted alias change. - Added output when script is using the reader. Update the hosts usage. - Lagoon has updated to use a comma separated list of host names. Add a condition to make sure trim didn't remove empty. Update govcms-deploy to check HOSTS. * Update to split on space as per PR. - amazeeio/dbaas-mariadb-apb#5 (comment) * Fixed added replicas in databases array. (#151) Co-authored-by: Alex Skrypnyk <alex@integratedexperts.com> Co-authored-by: Alex Skrypnyk <alex.designworks@gmail.com>
Let's try this again.
Add read replica support to the provisioner. This time the change is not breaking - if the readreplica secret is missing, then:
DB_READREPLICA_HOST
field in the secret will be empty.Also update README and add notes on development environment, along with scripts and a basic test suite.