Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/govcms 615 sanitize #3

Merged
merged 8 commits into from
Nov 7, 2018
Merged

Feature/govcms 615 sanitize #3

merged 8 commits into from
Nov 7, 2018

Conversation

ivangrynenko
Copy link
Contributor

Updated sanitise.sh to support GovCMS 8,
Activated sanitize.sh script.

@ivangrynenko ivangrynenko requested a review from stooit November 2, 2018 01:17
tobybellwood pushed a commit that referenced this pull request Nov 2, 2018
update file location
4fcb748 
 file to be repopulated in #3
@tobybellwood tobybellwood mentioned this pull request Nov 2, 2018
Merged
tobybellwood pushed a commit that referenced this pull request Nov 2, 2018
empty list of files to test
f8f84ce 
to populate in #3
stooit
stooit requested changes Nov 5, 2018
View reviewed changes
Copy link
Collaborator

@stooit stooit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go - except we need to add in the missing goss tests in tests/goss/sanitise.yaml

Just the equivalent of the D7 which confirms expects files are removed: https://github.com/govCMS/govcmslagoon/blob/master/tests/goss/sanitise.yaml

ivangrynenko
ivangrynenko commented Nov 7, 2018
View reviewed changes
.docker/sanitize.sh
rm -f $APP_DIR/web/web.config
rm -f $APP_DIR/web/robots.txt
rm -f $APP_DIR/web/.editorconfig
rm -rf $APP_DIR/web/core/tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing drupal core tests, to prevent attempts to execute it.

ivangrynenko
ivangrynenko commented Nov 7, 2018
View reviewed changes
tests/goss/sanitise.yaml
exists: false
/app/web/favicon.ico:
exists: false
/app/web/core/tests:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing that Drupal core tests directory does not exist, to prevent attempts to execute PHP files within it.

@stooit
Copy link
Collaborator

stooit commented Nov 7, 2018

Looks good to me, LGTM

@ivangrynenko ivangrynenko merged commit f28167a into master Nov 7, 2018
@tobybellwood tobybellwood deleted the feature/GOVCMS-615-sanitize branch October 4, 2019 12:11
steveworley pushed a commit that referenced this pull request Nov 6, 2019
# This is a combination of 5 commits.
b1f0069 
# This is the 1st commit message:

Add initial gitlab ci file.

# This is the commit message #2:

Gitlab CI validation errors.

# This is the commit message #3:

Update CI config.

# This is the commit message #4:

Update CI.

# This is the commit message #5:

Update ci.
steveworley pushed a commit that referenced this pull request Nov 6, 2019
# This is a combination of 8 commits.
d35e668 
# This is the 1st commit message:

Add initial gitlab ci file.

# This is the commit message #2:

Gitlab CI validation errors.

# This is the commit message #3:

Update CI config.

# This is the commit message #4:

Update CI.

# This is the commit message #5:

Update ci.

# This is the commit message #6:

Update the gitlab-ci file.

# This is the commit message #7:

Update CI

# This is the commit message #8:

Update CI
steveworley pushed a commit that referenced this pull request Nov 6, 2019
# This is a combination of 28 commits.
3dcfc12 
# This is the 1st commit message:

Add initial gitlab ci file.

# This is the commit message #2:

Gitlab CI validation errors.

# This is the commit message #3:

Update CI config.

# This is the commit message #4:

Update CI.

# This is the commit message #5:

Update ci.

# This is the commit message #6:

Update the gitlab-ci file.

# This is the commit message #7:

Update CI

# This is the commit message #8:

Update CI

# This is the commit message #9:

Use docker registry for caching the build.

# This is the commit message #10:

Update CI

# This is the commit message #11:

Update pull permissions.

# This is the commit message #12:

Update CI

# This is the commit message #13:

Update CI

# This is the commit message #14:

Update CI

# This is the commit message #15:

Update CI

# This is the commit message #16:

Update CI

# This is the commit message #17:

Update CI

# This is the commit message #18:

Update CI

# This is the commit message #19:

Update CI

# This is the commit message #20:

Update CI

# This is the commit message #21:

Update CI

# This is the commit message #22:

Update CI

# This is the commit message #23:

Update CI

# This is the commit message #24:

Update CI

# This is the commit message #25:

Update CI

# This is the commit message #26:

Update CI

# This is the commit message #27:

Update CI

# This is the commit message #28:

Update CI
steveworley added a commit that referenced this pull request Jan 20, 2020
@steveworley
# This is a combination of 3 commits.
2e51a3c 
# This is the 1st commit message:

Add read replica access.

Updates govcms-deploy to use the read replica for
Adds database config for the read replica
Introduces MARIADB_HOST_READREPLICA environment variable to control the mysql host.

# This is the commit message #2:

Add replicas to the default connection.
# This is the commit message #3:

Update .docker/images/govcms8/scripts/govcms-deploy
steveworley added a commit that referenced this pull request Jan 22, 2020
@steveworley
# This is a combination of 3 commits.
cb1d2e0 
# This is the 1st commit message:

Added a redirect to the default govcms icon.

# This is the commit message #2:

Update 230-favicon.conf
# This is the commit message #3:

Update 230-favicon.conf
steveworley added a commit that referenced this pull request May 5, 2020
@steveworley @AlexSkrypnyk
[GOVCMSD8-556]: Add read replica access. (#83)
40bf3fe 
* # This is a combination of 3 commits.
# This is the 1st commit message:

Add read replica access.

Updates govcms-deploy to use the read replica for
Adds database config for the read replica
Introduces MARIADB_HOST_READREPLICA environment variable to control the mysql host.

# This is the commit message #2:

Add replicas to the default connection.
# This is the commit message #3:

Update .docker/images/govcms8/scripts/govcms-deploy

* Add read replica access.

Updates govcms-deploy to use the read replica for
Adds database config for the read replica
Introduces MARIADB_HOST_READREPLICA environment variable to control the mysql host.

Add replicas to the default connection.

Update .docker/images/govcms8/scripts/govcms-deploy

Code review updates.

- Return early if host is unavailable.
- Updated db_conf settings for reusability.
- Redirect show tables to stderr.
- Reverted alias change.
- Added output when script is using the reader.

Update the hosts usage.

- Lagoon has updated to use a comma separated list of host names.

Add a condition to make sure trim didn't remove empty.

Update govcms-deploy to check HOSTS.

* Update to split on space as per PR.

- amazeeio/dbaas-mariadb-apb#5 (comment)

* Fixed added replicas in databases array. (#151)

Co-authored-by: Alex Skrypnyk <alex@integratedexperts.com>
Co-authored-by: Alex Skrypnyk <alex.designworks@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stooit stooit stooit approved these changes

@tobybellwood tobybellwood Awaiting requested review from tobybellwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivangrynenko @stooit