Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow common dev environment settings via DEV_MODE flag #14

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Allow common dev environment settings via DEV_MODE flag #14

merged 1 commit into from
Nov 29, 2018

Conversation

stooit
Copy link
Collaborator

@stooit stooit commented Nov 29, 2018

If a DEV_MODE flag is enabled in .env then default development settings will apply:

  • No CSS/JS aggregation
  • No GA tracking
  • Verbose error logging
  • Max cache age 0
  • Null cache backend

A development.services.yml file will also be included:

  • Twig debug enabled
  • Twig cache disabled
  • Twig autoload enabled
  • http.response.debug_cacheability_headers enabled

@stooit stooit requested review from thom8 and tobybellwood November 29, 2018 06:10
@stooit
Copy link
Collaborator Author

stooit commented Nov 29, 2018

Note: This will not do anything on it's own, the Scaffold needs this PR merging too: https://projects.govcms.gov.au/GovCMS/govcms8-scaffold/merge_requests/7/diffs

@stooit stooit merged commit afaf6d1 into master Nov 29, 2018
@tobybellwood tobybellwood deleted the feature/GOVCMS-839-dev-mode branch October 4, 2019 12:11
steveworley pushed a commit that referenced this pull request Nov 6, 2019
# This is a combination of 28 commits.
3dcfc12 
# This is the 1st commit message:

Add initial gitlab ci file.

# This is the commit message #2:

Gitlab CI validation errors.

# This is the commit message #3:

Update CI config.

# This is the commit message #4:

Update CI.

# This is the commit message #5:

Update ci.

# This is the commit message #6:

Update the gitlab-ci file.

# This is the commit message #7:

Update CI

# This is the commit message #8:

Update CI

# This is the commit message #9:

Use docker registry for caching the build.

# This is the commit message #10:

Update CI

# This is the commit message #11:

Update pull permissions.

# This is the commit message #12:

Update CI

# This is the commit message #13:

Update CI

# This is the commit message #14:

Update CI

# This is the commit message #15:

Update CI

# This is the commit message #16:

Update CI

# This is the commit message #17:

Update CI

# This is the commit message #18:

Update CI

# This is the commit message #19:

Update CI

# This is the commit message #20:

Update CI

# This is the commit message #21:

Update CI

# This is the commit message #22:

Update CI

# This is the commit message #23:

Update CI

# This is the commit message #24:

Update CI

# This is the commit message #25:

Update CI

# This is the commit message #26:

Update CI

# This is the commit message #27:

Update CI

# This is the commit message #28:

Update CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thom8 thom8 thom8 approved these changes

@tobybellwood tobybellwood Awaiting requested review from tobybellwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stooit @thom8