Address macos-latest update to arm-based MacOS 14 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added issue #390 to track cross-compilation. |
rmarrowstone
approved these changes
Nov 14, 2024
| @@ -97,7 +97,7 @@ jobs: | |||
| matrix: | |||
| include: | |||
| # See https://cibuildwheel.readthedocs.io/en/stable/options/#build-skip for more details. | |||
| - os: macos-latest | |||
| - os: macos-13 # macos-13 is the last non-large x86-based runner. Need to look into cross-compiling. | |||
There was a problem hiding this comment.
Don't understand what non-large means here.
There was a problem hiding this comment.
A better term would probably be standard runners. Runners that aren't -large, or -xlarge.
You can opt into large or x-large runners like macos-13-large. For intel, the standard (non-large) runners stop at MacOS 13 with macos-13-xlarge being Arm, but standard and large being intel. MacOS 14 flips to Arm for standard, and xlarge, but large is intel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
Prior to this PR the release workflow was relying on the
macos-latestrunner in order to buildx86_64wheels. Since our 0.12.0 release, themacos-latestrunner has become an alias formacos-14, which is an arm-based runner. This change causes our x86 wheel build to fail.Currently,
macos-13is the only standard x86-based MacOS runner.This PR changes our use of
macos-latesttomacos-13in order to regail x86 build capabilities. A future task should be taken up to use Arm-based runners to cross-compile x86.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.