Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address macos-latest update to arm-based MacOS 14 #389

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Address macos-latest update to arm-based MacOS 14 #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
matrix:
include:
# See https://cibuildwheel.readthedocs.io/en/stable/options/#build-skip for more details.
- os: macos-latest
- os: macos-13 # macos-13 is the last non-large x86-based runner. Need to look into cross-compiling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand what non-large means here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better term would probably be standard runners. Runners that aren't -large, or -xlarge.

You can opt into large or x-large runners like macos-13-large. For intel, the standard (non-large) runners stop at MacOS 13 with macos-13-xlarge being Arm, but standard and large being intel. MacOS 14 flips to Arm for standard, and xlarge, but large is intel.

arch: x86_64
cibw_arch: "x86_64"
- os: macos-14 # https://github.com/actions/runner-images?tab=readme-ov-file#available-images
Expand Down
Loading