add spec for callbacks #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
approved these changes
Feb 27, 2018
| private def _{{name.id}} | ||
| history << "{{name.id}}\n" | ||
| end | ||
| {% end %} |
|
Fixes #162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/amberframework/granite-orm/pull/153#discussion_r170689455
This PR explicitly specifies why
DB::Erroris rescued in#save. After this PR, we can detect #153 is well regressed. 😄In addition, this also ensures the callbacks are fired and its order.
Best regard,