spec: don't clear database automatically #165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current specs, every time we run one test case, we initialize 33 tables with 3 adapters in total.
This is expensive to run and is unnecessary work for most test cases. Therefore, execution of all tests is very slow and this cost will continue to increase each time additional functionality is added.
In this PR, I propose a policy to delete tables manually rather than automatically. When writing a test, we do not assume that the table is empty, we need to manually run the table as needed.
Benchmark
In my environment.
master
8m13s
(with 6118 DB operations)PR
43s
(with 1012 DB operations)FYI: This is a commits dependency for natural-key in my fork.
new_record?
,destroyed?
,persisted?
#153 add record statuses about persistenceprimary auto: false
works as a natural keyBest regards,