Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade ameba to v1.3.1 which requires crystal v1.6 #469

Merged
merged 8 commits into from
Dec 3, 2022
Merged

upgrade ameba to v1.3.1 which requires crystal v1.6 #469

merged 8 commits into from
Dec 3, 2022

Conversation

pan
Copy link
Contributor

@pan pan commented Nov 27, 2022

No description provided.

@pan
Copy link
Contributor Author

pan commented Dec 2, 2022

Now everything is fixed.

$ bin/ameba 
Inspecting 104 files

........................................................................................................

Finished in 872.03 milliseconds
104 inspected, 0 failures

drujensen
drujensen approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@drujensen drujensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. so much cleaner and easier to read. 💯

robacarp
robacarp approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Is it worthwhile to also add this to a github workflow?

@pan
Copy link
Contributor Author

pan commented Dec 3, 2022

Yes after another pull request is merged, crystal spec will also work.

@robacarp robacarp merged commit ddb5b58 into amberframework:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robacarp robacarp robacarp approved these changes

@drujensen drujensen drujensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pan @drujensen @robacarp