New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add #next_column_index to db mocker #470

Merged

crimson-knight merged 1 commit into amberframework:master from pan:next_column_index

Jan 18, 2023

Contributor

pan commented Nov 27, 2022

This is required by changes made in crystal-db v0.11.0


          add #next_column_index to db mocker

aa11ff8

This is required by changes made in crystal-db v0.11.0

pan mentioned this pull request

upgrade ameba to v1.3.1 which requires crystal v1.6 #469

Merged

Contributor Author

pan commented Dec 7, 2022

Without this change it will run into this compiling error.

$ crystal spec
Showing last frame. Use --error-trace for full trace.

In spec/mocks/db_mock.cr:47:1

 47 | class FieldEmitter < DB::ResultSet
      ^
Error: abstract `def DB::ResultSet#next_column_index()` must be implemented by FieldEmitter

robacarp approved these changes

View reviewed changes

crimson-knight merged commit 51e41d4 into amberframework:master

pan deleted the next_column_index branch

January 19, 2023 01:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet