-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FindPython3 instead of FindPythonInterp #355
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Full CI including ament/ament_package#134 |
Full CI again after ros2/ros2#1168
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of packages have custom logic for windows debug, e.g. https://github.com/ros2/rclpy/blob/fbe9ad12b806345a3b3c0578af7e21d1d6bc7bea/rclpy/CMakeLists.txt#L36.
I would also run a Windows debug job, just in case.
Full CI Windows Debug I'm expecting it to pass, since |
All 10 windows Debug test failures also occur in the Windows Debug nightly: https://ci.ros2.org/view/nightly/job/nightly_win_deb/2077/#showFailuresLink |
* First pass using FindPython3, no testing done Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Use config-time python to avoid CMP0087 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Set ament_package_PYTHON_EXECUTABLE Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * move getting executable path out of if block Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Fatal error if Python3::Interpreter not present Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove Python 2 logic Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Related to ros2/python_cmake_module#6
This is a work in progress that makes ament_cmake use
FindPython3
instead ofFindPythonInterp
.Requires ament/ament_package#134