Use FindPython3 instead of FindPythonInterp #7
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
force-pushed
the
use_FindPython3
branch
from
e4607ca
to
e29e74f
Compare
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
All right, I've rebased this onto the latest, and also updated it to export the PYTHON_EXECUTABLE and PYTHON_EXECUTABLE_DEBUG variables. That seems to keep most downstream things working, and succeeds in all my local tests. I'm going to run a full-up CI on this along with ros2/rosidl_python#140 to see what happens:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
I also pushed a fix for Windows, so let's see what happens now:
|
|
Let's see what happens with Windows Debug, RHEL, and clang:
|
|
Here's another try with the more recent code:
|
|
I've put a new fix in place in rosidl_python, which should fix Windows Debug. Here's another CI try:
|
|
One more CI with an additional fix in rosidl_python:
|
|
OK, I think I've now finally licked this on all platforms. This should get rid of our warnings. @sloretz if you get a chance, I'd appreciate a review from you on this and ros2/rosidl_python#140 , since I have made some substantial changes since you last opened it. |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Here's new Windows Debug CI, which is the one most likely to have an issue:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI again:
|
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Another fix for Windows is in, here is CI again: CI again:
|
|
Running |
This simplifies things so we no longer need a PythonExtra::Interpreter. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
use_FindPython3
branch
from
eb5e38e
to
72a7ec2
Compare
|
After the latest changes, here's another round of CI:
|
|
Linux AMD job needs a retrigger. |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
I put a linting fix in place, and fixed the review comments. Here is another round of CI:
|
|
Here's another try that includes ros-visualization/rqt_plot#93 and ros-visualization/rqt_bag#151:
|
|
And just to complete the set, here is RHEL and clang:
|
First pass at #6 - marking as draft because I've learned a few prerequisites
Python3::Interpreteris blocked byament_cmake_pytestand/orament_cmake_testlack of support for imported executable targetsPython3_add_libraryuse by rosidl generators is blocked by using non-keyword versions oftarget_link_libraries()Also:
I haven't tested ifI've tested it now, andfind_package(Python3 REQUIRED COMPONENTS ...)can be found multiple times with additional comments - if so then the documentation in this PR is incorrect.FindPython3can be found multiple times to get more components, so this PR can be a little bit simpler :)