Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uncrustify 0.78.1 config #475

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Conversation

marcoag
Copy link
Contributor

@marcoag marcoag commented Feb 21, 2024

Adding new uncrustify 0.78.1 config with the following options flipped from previous config to minimize impact in downstream users of the package (feel free to suggest other changes):

< Original values
> New values

< sp_before_sparen                = force   # ignore/add/remove/force/not_defined
---
> sp_before_sparen                = ignore # ignore/add/remove/force/not_defined

< sp_func_call_paren              = remove   # ignore/add/remove/force/not_defined
---
> sp_func_call_paren              = ignore # ignore/add/remove/force/not_defined

< nl_func_call_start_multi_line   = true    # true/false
---
> nl_func_call_start_multi_line   = false # true/false

< nl_class_brace = force
---
> nl_class_brace = ignore

This has been changed from default values, since it's a new option:
pp_multiline_define_body_indent = 2

Changes in main.py make sure the new config is only used if the system uncrustify version is 0.78.1 otherwise the old config is used.

@clalancette
Copy link
Contributor

clalancette commented Mar 20, 2024

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status
  • RHEL Build Status

clalancette and others added 7 commits March 20, 2024 17:51
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor

All right. The failing tests in CI are all otherwise flaky, so I'm going to go ahead and merge this one in.

@clalancette clalancette merged commit 1dc0e38 into ament:rolling Mar 21, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants