fix(generator): react-intl in externals (#83)

americanexpress · Aug 10, 2020 · ee5a759 · ee5a759
1 parent 764c44d
commit ee5a759
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/packages/generator-one-app-module/__tests__/app.js b/packages/generator-one-app-module/__tests__/app.js
@@ -153,7 +153,7 @@ describe('generator-one-app-module', () => {
       assert.jsonFileContent('package.json', {
         'one-amex': {
           bundler: {
-            externals: 'react-intl',
+            requiredExternals: ['react-intl'],
           },
         },
       });
@@ -221,7 +221,7 @@ describe('generator-one-app-module', () => {
       assert.jsonFileContent('package.json', {
         'one-amex': {
           bundler: {
-            providesExternals: 'react-intl',
+            providedExternals: ['react-intl'],
           },
         },
       });

diff --git a/packages/generator-one-app-module/generators/app/index.js b/packages/generator-one-app-module/generators/app/index.js
@@ -191,7 +191,7 @@ module.exports = class extends Generator {
         this.fs.extendJSON(this.destinationPath('package.json'), {
           'one-amex': {
             bundler: {
-              externals: 'react-intl',
+              requiredExternals: ['react-intl'],
             },
           },
         });
@@ -213,7 +213,7 @@ module.exports = class extends Generator {
               rootModuleName: this.modulePackageName,
             },
             bundler: {
-              providesExternals: 'react-intl',
+              providedExternals: ['react-intl'],
             },
           },
         });

diff --git a/packages/one-app-bundler/__tests__/webpack/module/webpack.server.spec.js b/packages/one-app-bundler/__tests__/webpack/module/webpack.server.spec.js
@@ -14,6 +14,10 @@
 
 jest.spyOn(process, 'cwd').mockImplementation(() => __dirname.split('/__tests__')[0]);
 
+jest.mock('read-pkg-up', () => ({
+  sync: jest.fn(() => ({ pkg: { name: '@americanexpress/one-app-bundler', version: '6.8.0' } })),
+}));
+
 const webpackConfig = require('../../../webpack/module/webpack.server');
 const { validateWebpackConfig } = require('../../../test-utils');