Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(generator): react-intl in externals #83

Merged
merged 5 commits into from
Aug 10, 2020

Conversation

infoxicator
Copy link
Contributor

@infoxicator infoxicator commented Jun 16, 2020

Fixed correct syntax for providedExternals to be an array of strings instead of a string.

Fixed issue with side effect in tests for one-app-bundler

@infoxicator infoxicator requested review from a team as code owners June 16, 2020 12:26
@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity.

Copy link
Contributor

@mtomcal mtomcal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@JamesSingleton JamesSingleton merged commit ee5a759 into master Aug 10, 2020
@JamesSingleton JamesSingleton deleted the feature/generator-externals branch August 10, 2020 21:42
github-actions bot pushed a commit that referenced this pull request May 17, 2021
# @americanexpress/generator-one-app-module-v1.0.0-beta.1 (2021-05-17)

### Bug Fixes

* **deps:** update one-app-ducks to 4.3.1 ([#230](#230)) ([c466a3e](c466a3e))
* **generator:** react-intl in externals ([#83](#83)) ([ee5a759](ee5a759))
* **generator:** remove deprecated holocron api ([#65](#65)) ([8d8564a](8d8564a))

### Features

* **deps:** update generated module deps ([#153](#153)) ([865bf24](865bf24))
* **deps:** update generator deps for react-intl and parrot-generator ([ac24226](ac24226))
* **generator:** add app compatibility to generator ([5412b1f](5412b1f))
* **generator:** add generator-one-app-module ([#13](#13)) ([0fd994b](0fd994b))
* **generator:** add one-app-runner script ([#96](#96)) ([e1d0e63](e1d0e63))
* **generator:** adds .build-cache to gitignore ([d6f3235](d6f3235))
* **generator:** csp report-uri to ONE_CLIENT_CSP_REPORTING_URL ([#50](#50)) ([9ae5dc9](9ae5dc9))
* **generator:** update base-module template ([#25](#25)) ([1a0af74](1a0af74))
* **yarn2:** update to yarn 2 ([f583464](f583464))
@oneamexbot
Copy link

🎉 This PR is included in version @americanexpress/generator-one-app-module-v1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants