This repository has been archived by the owner on May 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
fix(generator): react-intl in externals #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is stale because it has been open 30 days with no activity. |
10xLaCroixDrinker
approved these changes
Aug 10, 2020
mtomcal
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 👍
JamesSingleton
approved these changes
Aug 10, 2020
Francois-Esquire
approved these changes
Aug 10, 2020
JAdshead
approved these changes
Aug 10, 2020
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2021
# @americanexpress/generator-one-app-module-v1.0.0-beta.1 (2021-05-17) ### Bug Fixes * **deps:** update one-app-ducks to 4.3.1 ([#230](#230)) ([c466a3e](c466a3e)) * **generator:** react-intl in externals ([#83](#83)) ([ee5a759](ee5a759)) * **generator:** remove deprecated holocron api ([#65](#65)) ([8d8564a](8d8564a)) ### Features * **deps:** update generated module deps ([#153](#153)) ([865bf24](865bf24)) * **deps:** update generator deps for react-intl and parrot-generator ([ac24226](ac24226)) * **generator:** add app compatibility to generator ([5412b1f](5412b1f)) * **generator:** add generator-one-app-module ([#13](#13)) ([0fd994b](0fd994b)) * **generator:** add one-app-runner script ([#96](#96)) ([e1d0e63](e1d0e63)) * **generator:** adds .build-cache to gitignore ([d6f3235](d6f3235)) * **generator:** csp report-uri to ONE_CLIENT_CSP_REPORTING_URL ([#50](#50)) ([9ae5dc9](9ae5dc9)) * **generator:** update base-module template ([#25](#25)) ([1a0af74](1a0af74)) * **yarn2:** update to yarn 2 ([f583464](f583464))
🎉 This PR is included in version @americanexpress/generator-one-app-module-v1.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed correct syntax for
providedExternals
to be an array of strings instead of a string.Fixed issue with side effect in tests for one-app-bundler