Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix(generator): remove deprecated holocron api #65

Merged
merged 1 commit into from
Apr 29, 2020
Merged

fix(generator): remove deprecated holocron api #65

merged 1 commit into from
Apr 29, 2020

Conversation

infoxicator
Copy link
Contributor

Removed holocronModule HOC from the following generators

  • int-child-module
  • intl-root-module

updated base-child-module holocron dependency to ^1.1.0

@infoxicator infoxicator requested review from a team as code owners April 27, 2020 15:29
Copy link
Contributor

@mtomcal mtomcal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have any docs to update related to this for the generator?

@infoxicator
Copy link
Contributor Author

I think the only docs are in the holocron API which has been updated in this PR americanexpress/holocron#27

I only changed the templates the commands haven't changed but could be wrong...

@infoxicator infoxicator merged commit 8d8564a into americanexpress:master Apr 29, 2020
@infoxicator infoxicator deleted the fix/generator-holocron-api branch April 29, 2020 09:38
github-actions bot pushed a commit that referenced this pull request May 17, 2021
# @americanexpress/generator-one-app-module-v1.0.0-beta.1 (2021-05-17)

### Bug Fixes

* **deps:** update one-app-ducks to 4.3.1 ([#230](#230)) ([c466a3e](c466a3e))
* **generator:** react-intl in externals ([#83](#83)) ([ee5a759](ee5a759))
* **generator:** remove deprecated holocron api ([#65](#65)) ([8d8564a](8d8564a))

### Features

* **deps:** update generated module deps ([#153](#153)) ([865bf24](865bf24))
* **deps:** update generator deps for react-intl and parrot-generator ([ac24226](ac24226))
* **generator:** add app compatibility to generator ([5412b1f](5412b1f))
* **generator:** add generator-one-app-module ([#13](#13)) ([0fd994b](0fd994b))
* **generator:** add one-app-runner script ([#96](#96)) ([e1d0e63](e1d0e63))
* **generator:** adds .build-cache to gitignore ([d6f3235](d6f3235))
* **generator:** csp report-uri to ONE_CLIENT_CSP_REPORTING_URL ([#50](#50)) ([9ae5dc9](9ae5dc9))
* **generator:** update base-module template ([#25](#25)) ([1a0af74](1a0af74))
* **yarn2:** update to yarn 2 ([f583464](f583464))
@oneamexbot
Copy link

🎉 This PR is included in version @americanexpress/generator-one-app-module-v1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants