This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Update holocron - provide rejected modules #962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 687 kB ℹ️ View Unchanged
|
JAdshead
force-pushed
the
feat/handle-rejected-modules
branch
from
March 27, 2023 20:52
0e0e2ce
to
3b6944f
Compare
JAdshead
changed the title
WIP: holocron provide rejected externals
Update holocron - provide rejected externals
Mar 27, 2023
JAdshead
changed the title
Update holocron - provide rejected externals
Update holocron - provide rejected modules
Mar 27, 2023
Matthew-Mallimo
suggested changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments
Matthew-Mallimo
approved these changes
Mar 28, 2023
10xLaCroixDrinker
approved these changes
Mar 29, 2023
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consuming the latest Holocron version which includes rejected module updates.
Makes use of rejected modules to provide additional logs and reset the module map poll time.
Additional PR should follow which adds the rejected module information in the metrics.
Motivation and Context
After Holocron resiliency update one-app no longer reset when a module is rejected. The error is also logged only once which reduces the visibility of the error.
The aim of this is to improve DX when modules rejected.
How Has This Been Tested?
Locally and test suite.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?