Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(pollModuleMap): holocron provide rejected externals #965

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

JAdshead
Copy link
Contributor

Description

backport for #962

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@JAdshead JAdshead marked this pull request as ready for review March 29, 2023 20:28
@JAdshead JAdshead requested review from a team as code owners March 29, 2023 20:28
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 666 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 161 kB
./build/app/app~vendors.js 377 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 114 kB

compressed-size-action

@JAdshead JAdshead enabled auto-merge (squash) March 29, 2023 22:23
@JAdshead JAdshead merged commit 3ee6569 into 5.x.x Mar 30, 2023
@JAdshead JAdshead deleted the feat/update-holocron-rejected-modules-5.x.x branch March 30, 2023 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants