Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Update holocron - provide rejected modules #962

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Mar 27, 2023

Description

Consuming the latest Holocron version which includes rejected module updates.
Makes use of rejected modules to provide additional logs and reset the module map poll time.

Additional PR should follow which adds the rejected module information in the metrics.

Motivation and Context

After Holocron resiliency update one-app no longer reset when a module is rejected. The error is also logged only once which reduces the visibility of the error.
The aim of this is to improve DX when modules rejected.

How Has This Been Tested?

Locally and test suite.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

Size Change: 0 B

Total Size: 687 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 389 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 120 kB

compressed-size-action

@JAdshead JAdshead force-pushed the feat/handle-rejected-modules branch from 0e0e2ce to 3b6944f Compare March 27, 2023 20:52
@JAdshead JAdshead marked this pull request as ready for review March 27, 2023 20:55
@JAdshead JAdshead requested review from a team as code owners March 27, 2023 20:55
@JAdshead JAdshead changed the title WIP: holocron provide rejected externals Update holocron - provide rejected externals Mar 27, 2023
@JAdshead JAdshead changed the title Update holocron - provide rejected externals Update holocron - provide rejected modules Mar 27, 2023
@JAdshead JAdshead enabled auto-merge (squash) March 28, 2023 17:06
Copy link
Member

@Matthew-Mallimo Matthew-Mallimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

@Matthew-Mallimo Matthew-Mallimo requested a review from a team March 28, 2023 17:40
@Matthew-Mallimo Matthew-Mallimo requested a review from a team March 28, 2023 18:05
@JAdshead JAdshead merged commit dfc8745 into main Mar 29, 2023
@JAdshead JAdshead deleted the feat/handle-rejected-modules branch March 29, 2023 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants