Deprecations Warning Rails 6

[vladvinnikov]

When run specs for rails 5.2.x i receive

DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s). 

This is because i have complex plain SQL for ordering, and now order in rails must be encoded with Arel.sql to process unsafe sql.

See https://github.com/rails/rails/commit/310c3a8f2d043f3d00d3f703052a1e160430a2c2

[felixbuenemann]

This won't work as is, because you can also pass stuff like order: { id: :desc }.

The easiest solution would be to check if configuration[:order].respond_to? :to_sql and then call to_sql and wrap the result in Arel.sql. However that will cause a database connection to be established during class load and that is bad.

I'll have to think about this problem.

[felixbuenemann]

I've merged #79 which should address this problem.

You should wrap the :order option in Arel.sql() yourself, because acts_as_tree tries to support all valid ways to support order in ActiveRecord.

I'm currently doing some maintenance and will release a new gem with the changes soon.

[felixbuenemann]

@vladvinnikov acts_as_tree 2.9.0 has been released on rubygems.

[vladvinnikov]

@vladvinnikov acts_as_tree 2.9.0 has been released on rubygems.

Great! Works as expected without warnings (i use Arel.sql as and order param).