Fix order option with arel nodes #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes:
> ActiveRecord::StatementInvalid: SQLite3::ConstraintException:
> UNIQUE constraint failed: schema_migrations.version:
> INSERT INTO "schema_migrations" (version) VALUES ('1')
|
Also pushed a change that should fix the following exception in the test suite, which is caused by newer sqlite versions that support UNIQUE contraints:
|
this is technically not needed, but we would otherwise need to specify a compatible version for each rails major in gemfiles and all versions including 6.x support 1.3.6+ so iot should be fine for now.
|
Looks like only Rails 3.0 and 5.2+ work with sqlite 1.4, so to avoid touching all the gemfiles, I followed the example from #78 and locked down to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code uses
.inspectwithin eval, so it only works if inspect returns the actual ruby representation of the code, it works with stuff likenilor{id: :desc}, but completely breaks for things likeArel.sql('"foo" DESC, "bar" ASC').Fixes #78