Fix 0.12 template #101
Closed
Fix 0.12 template #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to build a project created with `amethyst new -a 0.12.0` would raise warnings about usused imports.
Merged
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 3 3
Lines 34 34
=======================================
Hits 32 32
Misses 2 2Continue to review full report at Codecov.
|
Dispersia
approved these changes
Dec 12, 2019
bors bot
added a commit
that referenced
this pull request
Dec 26, 2019
98: Add 0.13 template r=jojolepro a=0x6273 ~~Fixes warnings about unused imports in the 0.12 template, and adds a 0.13.2 template (identical to the 0.12 one).~~ Adds a 0.13 template. Some things were moved into a separate pr #101 as requested by a reviewer. Fixes #97 Co-authored-by: 0x40 <0x40@keemail.me>
bors bot
added a commit
that referenced
this pull request
Dec 26, 2019
101: Fix 0.12 template r=jojolepro a=0x6273 Fixes warnings about unused imports in the 0.12 template, and changes the asset path to "assets" instead of the root of the project dir. This was originally part of #98 but was moved to a separate pr as requested. Co-authored-by: 0x40 <0x40@keemail.me>
Build failed |
bors bot
added a commit
that referenced
this pull request
Mar 24, 2020
98: Add 0.13 template r=azriel91 a=0x6273 ~~Fixes warnings about unused imports in the 0.12 template, and adds a 0.13.2 template (identical to the 0.12 one).~~ Adds a 0.13 template. Some things were moved into a separate pr #101 as requested by a reviewer. Fixes #97 Co-authored-by: 0x40 <0x40@keemail.me>
|
👋 I'm closing all PRs and Issues since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings about unused imports in the 0.12 template, and changes the asset path to "assets" instead of the root of the project dir. This was originally part of #98 but was moved to a separate pr as requested.