Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 0.13 template #98

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Add 0.13 template #98

merged 3 commits into from
Mar 24, 2020

Conversation

0x6273
Copy link
Contributor

@0x6273 0x6273 commented Dec 2, 2019 •
edited
Loading

Fixes warnings about unused imports in the 0.12 template, and adds a 0.13.2 template (identical to the 0.12 one).

Adds a 0.13 template. Some things were moved into a separate pr #101 as requested by a reviewer.

Fixes #97

@azriel91
Copy link
Member

azriel91 commented Dec 2, 2019

Hm, travis windows builds aren't liking it, maybe because they haven't got symlinks enabled for git?

@0x6273
Copy link
Contributor Author

0x6273 commented Dec 2, 2019

Hm, travis windows builds aren't liking it, maybe because they haven't got symlinks enabled for git?

Seems like on windows, cargo install --git doesn't handle git symlinks properly. It works with git clone and cargo install --path .. So I guess symlinks can't be used until this cargo bug is fixed. I just copied the dir and force-pushed.

azriel91
azriel91 approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@azriel91 azriel91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks!

@azriel91
Copy link
Member

azriel91 commented Dec 2, 2019

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 2, 2019

🔒 Permission denied

Existing reviewers: click here to make azriel91 a reviewer

@azriel91
Copy link
Member

azriel91 commented Dec 2, 2019

Wow. Bors plz 😛
(gotta wait for someone else to come online)

@codecov-io
Copy link

codecov-io commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           3        3           
  Lines          34       34           
=======================================
  Hits           32       32           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d7c147...1528dd8. Read the comment docs.

@Quetzal2 Quetzal2 mentioned this pull request Dec 11, 2019
Closed
@azriel91
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 12, 2019

🔒 Permission denied

Existing reviewers: click here to make azriel91 a reviewer

@azriel91 azriel91 mentioned this pull request Dec 12, 2019
Merged
@0x6273 0x6273 mentioned this pull request Dec 12, 2019
Closed
@0x6273 0x6273 force-pushed the add_0.13_template branch 2 times, most recently from ee50a82 to 1528dd8 Compare December 12, 2019 22:01
AnneKitsune
AnneKitsune approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@AnneKitsune AnneKitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Thanks!

bors bot added a commit that referenced this pull request Dec 26, 2019
@bors @0x6273
Merge #98
689fff7 
98: Add 0.13 template r=jojolepro a=0x6273

~~Fixes warnings about unused imports in the 0.12 template, and adds a 0.13.2 template (identical to the 0.12 one).~~

Adds a 0.13 template. Some things were moved into a separate pr #101 as requested by a reviewer.

Fixes #97 

Co-authored-by: 0x40 <0x40@keemail.me>
@bors
Copy link
Contributor

bors bot commented Dec 26, 2019

Build failed

bors bot added a commit that referenced this pull request Dec 26, 2019
@bors @0x6273
Merge #101
006898c 
101: Fix 0.12 template r=jojolepro a=0x6273

Fixes warnings about unused imports in the 0.12 template, and changes the asset path to "assets" instead of the root of the project dir. This was originally part of #98 but was moved to a separate pr as requested.

Co-authored-by: 0x40 <0x40@keemail.me>
@AnneKitsune
Copy link
Contributor

image

@0x6273
Copy link
Contributor Author

0x6273 commented Dec 29, 2019

I think that's unrelated to my changes, since it doesn't touch that file. I guess new lints were added to clippy. I made a new pr that addresses the lint warnings. #103

@azriel91
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Dec 29, 2019

🔒 Permission denied

Existing reviewers: click here to make azriel91 a reviewer

@0x6273
Copy link
Contributor Author

0x6273 commented Jan 5, 2020

@Jojolepro this and #101 can be merged now :)

@AnneKitsune
Copy link
Contributor

bors r+

@wingyplus wingyplus mentioned this pull request Jan 31, 2020
Merged
@azriel91
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 24, 2020

Build succeeded

@bors bors bot merged commit f8a8c61 into amethyst:master Mar 24, 2020
bors bot added a commit that referenced this pull request Mar 24, 2020
@bors @wingyplus @azriel91
Merge #105
e5b265e 
105: Add 0.14 template r=azriel91 a=wingyplus

Hi, 

I just added amethyst 0.14.0 template to this project. This changes add by following comments on the PR #98. 

Co-authored-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Co-authored-by: Azriel Hoh <azriel91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dispersia Dispersia Dispersia left review comments

@azriel91 azriel91 azriel91 approved these changes

@AnneKitsune AnneKitsune AnneKitsune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amethyst new <name> do not compile in 0.13.2
5 participants
@0x6273 @azriel91 @codecov-io @AnneKitsune @Dispersia