Check on if the install and build paths coincide #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
force-pushed
the
feature/cmake_install_check
branch
from
4f141ae to
611d23f
Compare
traversaro
approved these changes
Mar 23, 2021
prashanthr05
approved these changes
Mar 23, 2021
|
Thank you @S-Dafarra! This PR is indeed really useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks if the installation path coincides with the source one. If not, it causes a configuration failure. It can be disabled if necessary.
I also added spdlog among the exported dependencies (we definitely need a check also for this) and fixed the CppAd installation folder.