Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SO3 task in TSID #281

Merged
merged 4 commits into from
Apr 19, 2021
Merged

Implement SO3 task in TSID #281

merged 4 commits into from
Apr 19, 2021

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Apr 19, 2021

As written in the title the PR implements the SO3Task in tsid. I also wrote a simple test to spot possible bugs.

@GiulioRomualdi GiulioRomualdi added the enhancement New feature or request label Apr 19, 2021
@GiulioRomualdi GiulioRomualdi self-assigned this Apr 19, 2021
@GiulioRomualdi GiulioRomualdi force-pushed the TSID/SO3_task branch 2 times, most recently from 5fefa9b to 3671a31 Compare April 19, 2021 12:45

public:
/**
* Initialize the planner.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual copy-paste 😁

* @param variablesHandler reference to a variables handler.
* @note The handler must contain a variable named as the parameter
* `robot_acceleration_variable_name` stored in the parameter handler. The variable represents
* the generalized acceleration of the robot. Where the generalized robot acceleration is a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the generalized acceleration of the robot. Where the generalized robot acceleration is a
* the generalized acceleration of the robot, where the generalized robot acceleration is a

bool update() override;

/**
* Set the desired reference trajectory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Set the desired reference trajectory.
* Set the desired reference point.

@GiulioRomualdi GiulioRomualdi merged commit c4b9172 into master Apr 19, 2021
@GiulioRomualdi GiulioRomualdi deleted the TSID/SO3_task branch April 19, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants