-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement YarpParametersHandler bindings #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good to me 👍 I didn't catch anything off.
#311 should fix the error in the tests |
GiulioRomualdi
force-pushed
the
bindings/ParametersHandlerYarp
branch
2 times, most recently
from
May 26, 2021 07:58
4d6e123
to
ebfeb54
Compare
#313 should fix the last bug |
GiulioRomualdi
force-pushed
the
bindings/ParametersHandlerYarp
branch
from
May 26, 2021 11:01
ebfeb54
to
98ade51
Compare
CI failure is now related to |
- Implement get_group method in IParameterHandler python bindings
GiulioRomualdi
force-pushed
the
bindings/ParametersHandlerYarp
branch
from
May 26, 2021 20:55
3c1e59b
to
f900479
Compare
Failure fixed in #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the python bindings for the
YarpParametersHandler
class.It is possible to load the parameters directly from the configuration file thanks to
set_from_file
method. While writing the tests I noticed a bug in thesetParameter
method for theYarpParametersHandler
#308. I think this is te reason why the test is failing: