Implement the CoMZMP controller #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
reviewed
Aug 9, 2021
...fiedModelControllers/include/BipedalLocomotion/SimplifiedModelControllers/CoMZMPController.h
Outdated
Show resolved
Hide resolved
...fiedModelControllers/include/BipedalLocomotion/SimplifiedModelControllers/CoMZMPController.h
Outdated
Show resolved
Hide resolved
...fiedModelControllers/include/BipedalLocomotion/SimplifiedModelControllers/CoMZMPController.h
Show resolved
Hide resolved
...fiedModelControllers/include/BipedalLocomotion/SimplifiedModelControllers/CoMZMPController.h
Outdated
Show resolved
Hide resolved
|
Are you planning to add some test, even just to check that there are no segmentation faults? |
S-Dafarra
reviewed
Aug 9, 2021
|
@S-Dafarra in af8e865 I implemented the test |
S-Dafarra
approved these changes
Aug 11, 2021
| bool m_isInitalized{false}; | ||
| }; | ||
|
|
||
| } // namespace Contacts |
|
The Ubuntu CI fails because of #389 |
- CoMZMPController inherits from advanceable - The overall documentation has been improved - Code duplication is reduced
GiulioRomualdi
force-pushed
the
feature/CoMZMPController
branch
from
c85bdc0
to
a5fb3d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issues closes #384