Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the TOML and YARP implementation of the parameters handler when a std::vector<bool> is passed to the setParameter() #390

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Aug 11, 2021

This fixes the problem spotted by @traversaro in #381.
It implements what is explained in #381 (comment)

  • Enable TOMLPlusPlus in CI

@GiulioRomualdi GiulioRomualdi self-assigned this Aug 11, 2021
@GiulioRomualdi
Copy link
Member Author

In #391, I'm checking the tomlplusplus installation

@GiulioRomualdi GiulioRomualdi force-pushed the fix/parametersHandler_vector_bool branch from 9a3f4da to 3077552 Compare August 11, 2021 15:27
@GiulioRomualdi GiulioRomualdi added the bugfix Fix a critical bug in the existing code label Aug 11, 2021
@GiulioRomualdi GiulioRomualdi changed the title Fix the parameters handler Toml and Yarp implementation when a std::vector<bool> is passed to setParameter() Fix the TOML and YARP implementation of the parameters handler when a std::vector<bool> is passed to the setParameter() Aug 11, 2021
@GiulioRomualdi GiulioRomualdi merged commit 585d377 into master Aug 11, 2021
@GiulioRomualdi GiulioRomualdi deleted the fix/parametersHandler_vector_bool branch August 11, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a critical bug in the existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants